test: DO NOT MERGE — validate dry-run git-ref repin (actions#124)#62
Closed
gethinwebster wants to merge 5 commits into
Closed
test: DO NOT MERGE — validate dry-run git-ref repin (actions#124)#62gethinwebster wants to merge 5 commits into
gethinwebster wants to merge 5 commits into
Conversation
Adds a deliberately-broken required peer (react-dom>=18) that only breaks consumers if they resolve build-tools from THIS PR, and points the dry-run at the actions self-test branch. Expected: consumer dry-run jobs go RED with an ERESOLVE citing this PR's build-tools commit — proving the repin fired. Against actions@main today this would stay GREEN (consumers resolve #main).
…ild-tools self-build passes and consumers hit the repin
…6 react-dom peer)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proves that actions#124 (pin the changed package's
github:#<ref>deps to the PR commit in the dry-run) actually closes the coverage gap that let build-tools#55 through.What this PR does
react-dom: ">=18.0.0". Consumers pinreact-dom@^16.14, so this can only ERESOLVE if a consumer resolves build-tools from this PR.dry-run.yml@dev-gethinw-dryrun-git-ref-pin-selftest), which carries #124's fix with all nested action refs repointed so the whole chain runs the fix.Expected result (proof)
ERESOLVE … peer react-dom@">=18.0.0" from @cloudscape-design/build-tools … github:cloudscape-design/build-tools#<this-PR-sha>— the PR sha in the source confirms the repin fired.actions@maintoday the same PR would stay GREEN (consumers resolve build-tools from live#main, which has no such peer) — that's the blind spot #124 fixes.Delete this branch and the actions self-test branch after validation.